phpCollab Community
Discuss everything phpCollab!

The forums are currently in READ-ONLY mode while we upgrade the forums.
Home » Development » Modifications » MOD: phpCollab 2.5 patched
MOD: phpCollab 2.5 patched [message #2122] Sun, 01 June 2003 17:42 Go to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader


what kind of permission to the newsdek?[ 14 votes ]
1. users 2 / 14%
2. project manager 8 / 57%
3. project administrator 3 / 21%
4. administrator 1 / 7%

I'm writing a patched version of the 2.5beta with:

- newsdesk mod + notification (by urbanfalcon)
- admin login (by urbanfalcon)
- emailusers mod (by urbanfalcon)
- all the pdf module (by abilstein)

all the module are included in the installer (updater also),
so the creation of the new table and new variabiles in the settings.php file will be automagically made! Very Happy

here 3 snapshot of the rewriting of the newsdesk mod
main module page - add news - view news

what I added to the mods:
- newsdesk:
---- RSS syndacation file, the news are saved also to a RSS 0.91 valid file, soon I'll add also a RSS 2.0
---- the rewriting of the code to use the PHPC db api
---- the rewriting of the code to use the PHPC render api
---- new script[''] vars in the lang_en.php e lang_it.php
---- division of the code to 3 main file: listnews.php, delnews.php, editnews.php instead only one.

- admin login
---- added a var in the setting.php to choose where the admin will log (if admin panel or home page)

what I need to finish my work:
a good esplanation of how does work the sorting procedures in the PHPC render API:
ie.
$block1->sorting("newsdesk",$sortingUser->sor_organizations[0],"news.pdate DESC",$sortingFields = array(0=>"news.title",1=>"news.pdate"));


what is $sortingUser->sor_organizations[0] ?

soon I'll release this patched version... if someone want It now send me a PM...

ciuaz
MOD: phpCollab 2.5 patched [message #2135] Mon, 02 June 2003 18:09 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

I've added a poll to the post because I would to know to who I can leave the permission to add a news.

please note that giving the right to the user means to give the rights to all!

I'll added a new screenshot of the viewnews.php with all the comments here

ps
there's someone who esplain me how work the sorting and what is the borne?
$blockPage->bornesNumber = "1";
$blockPage->returnBorne("1");


PLEEEASE! Crying or Very Sad
MOD: phpCollab 2.5 patched [message #2137] Mon, 02 June 2003 23:50 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

ok, the 2.5 hacked version is quite finished,
you can test and download here:
http://nanoc.no-ip.org/phpcollab/

you can test the RSS code here:
http://nanoc.no-ip.org/phpcollab/phpcollab/newsdesk/rss.php

what I've done:
- newsDesk + notification (urbanFalcon)
---- completely rewrite newsdesk code to make it PHPC api compliant
---- added RSS 0.91
---- added $scripts[] reference in lang_en.php e lang_it.php

- mailusers (urbanFalcon, Abilstein)
---- rewrite of the code to make it PHPC api 100% compliant
---- added the icon to all the standard theme
---- correct some breadCrumb

- exportUsers & exportReport (Abilstein)
---- was ok Very Happy

- admin login (urbanFalcon)
---- added a variable in the settings.php to decide to activate the homepage for the admin

- Protect project from non-team members. (urbanFalcon)
----- added the 1.2 code

- task & project autocompletion (fdeckert)
---- was ok Very Happy

TODO
- newsDesk
---- add RSS 2.0 support
---- add PDF exportation
---- add a better gui to add complex article (with html code)
---- modify the newsposts table to add user email and url reference for the article.
---- choose the security level access to the script

hope you'll like this!

ciuaz
Question [message #2138] Tue, 03 June 2003 02:37 Go to previous messageGo to next message
urbanfalcon is currently offline  urbanfalcon
Messages: 235
Registered: January 2003
Location: new york
phpCollab contributor
Site Admin

I'm still using 2.3 because I can't afford to have any hiccups with my phpcollab core installation right now (some people have had issues with passwords and logins after upgrading to 2.4 from 2.3 in the past - i have too many clients that would be put off by this). How far will the new Newsdesk be from the 2.3 code? Is it something that I might be able to implement with a few tweaks or will it require a phpcollab upgrade?
One more thing... [message #2139] Tue, 03 June 2003 02:41 Go to previous messageGo to next message
urbanfalcon is currently offline  urbanfalcon
Messages: 235
Registered: January 2003
Location: new york
phpCollab contributor
Site Admin

Your demo test/test account doesn't seem to work now...I tried and it gave me a session error! Crying or Very Sad
MOD: phpCollab 2.5 patched [message #2140] Tue, 03 June 2003 03:32 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

urbanfalcon

Your demo test/test account doesn't seem to work now...I tried and it gave me a session error!


I've notice that, it's a php 4.2.1 session problem I'll fix tomorrow... with the 4.3.2 version, it work if you try sometimes (10/15 times Crying or Very Sad )

urbanfalcon

How far will the new Newsdesk be from the 2.3 code? Is it something that I might be able to implement with a few tweaks or will it require a phpcollab upgrade?


I think that was very different from 2.3 code, because I use a lot of PHPC api (like buildLink() that doesn't exist in the 2.3 version), but I never coded on it before 2.4 so I cannot of every api calling.

to use my code you need to modify:

includes/settings.php
includes/messages.php
includes/request.class.php
includes/lybrary.php
includes/initrequests.php
themes/default/header.php
Hmmm [message #2141] Tue, 03 June 2003 03:40 Go to previous messageGo to next message
urbanfalcon is currently offline  urbanfalcon
Messages: 235
Registered: January 2003
Location: new york
phpCollab contributor
Site Admin

I have been able to rig other mods that use buildLink() for 2.3, it's not as pretty but it works with the same functionality. When you feel like you're pushed the code as far as it can go, can you put the files you've changed for the updated Newsdesk together in a .zip file or something? I could back up my installation of phpCollab and try my luck at integrating what you've done. Where you went with it is basically where I wanted to go, but I just haven't had a lot of time to work on it beyond just getting from a concept to a basic working product.
MOD: phpCollab 2.5 patched [message #2142] Tue, 03 June 2003 03:59 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

here the modify listed file per file:

settings.php search:
$tableCollab["bookmarks_categories"] = "bookmarks_categories";
add after:
$tableCollab["newsdeskcomments"] = "newsdeskcomments";
$tableCollab["newsdeskposts"] = "newsdeskposts";


messages.php search:
case settingsNotwritable:
$msgLabel = "<b>".$strings["attention"]."</b> : ".$strings["settings_notwritable"];
break;
add after:
case blankNews:
$msgLabel = "<b>".$strings["attention"]."</b> : ".$strings["blank_newsdesk"];
break;

case removeNews:
$msgLabel = "<b>".$strings["success"]."</b> : ".$strings["remove_newsdesk"];
break;

case blankComment:
$msgLabel = "<b>".$strings["success"]."</b> : ".$strings["blank_newsdesk_comment"];
break;

case removeComment:
$msgLabel = "<b>".$strings["success"]."</b> : ".$strings["remove_newsdesk_comment"];
break;


request.class.php search:
$this->sor_invoices[] = $row[25]);
add after:
$this->sor_newsdesk[] = ($row[26]);

search:
$index = $this->query($sql);
while($this->fetch()) {
	$this->boocat_id[] = ($row[0]);
	$this->boocat_name[] = ($row[1]);
	$this->boocat_description[] = ($row[2]);
}
$this->close();
}
add after:
//results newsdeskpost 29/05/2003 by fullo
function openNewsDesk($querymore,$start="",$rows="") {
global $tableCollab, $strings, $res, $row, $databaseType, $initrequest;
$this->connectClass();
$sql = $initrequest["newsdeskposts"];
$sql .= ' '.$querymore;
if (($databaseType == "mysql") && $start != "") {
$sql .= " LIMIT $start,$rows";
}
if ($databaseType == "postgresql" && $start != "") {
$sql .= " LIMIT $rows,$start";
}

$index = $this->query($sql);
while($this->fetch()) {
	$this->news_id[] = ($row[0]);
	$this->news_date[] = ($row[1]);
	$this->news_title[] = ($row[2]);
	$this->news_author[] = ($row[3]);
	$this->news_content[] = ($row[4]);
}
$this->close();
}

// results newsdeskcomments 02/06/2003 by fullo
function openNewsDeskComments($querymore,$start="",$rows="") {
global $tableCollab, $strings, $res, $row, $databaseType, $initrequest;
$this->connectClass();
$sql = $initrequest["newsdeskcomments"];
$sql .= ' '.$querymore;
if (($databaseType == "mysql") && $start != "") {
$sql .= " LIMIT $start,$rows";
}
if ($databaseType == "postgresql" && $start != "") {
$sql .= " LIMIT $rows,$start";
}

$index = $this->query($sql);
while($this->fetch()) {
	$this->newscom_id[] = ($row[0]);
	$this->newscom_postid[] = ($row[1]);
	$this->newscom_name[] = ($row[2]);
	$this->newscom_comment[] = ($row[3]);
}
$this->close();
}


initrequests.php search:
$initrequest["bookmarks_categories"] = "SELECT boocat.*
FROM ".$tableCollab["bookmarks_categories"]." boocat
";
add after:
//29/05/2003 fullo
$initrequest["newsdeskposts"] = "SELECT news.*
FROM ".$tableCollab["newsdeskposts"]." news 
";

//02/06/2003 fullo
$initrequest["newsdeskcomments"] = "SELECT newscom.*
FROM ".$tableCollab["newsdeskcomments"]." newscom 
";


/language/lang_en.php add these lines
$strings["newsdesk"] = "Newsdesk";
$strings["newsdesk_list"] = "News list";
$strings["article_newsdesk"] = "News Body";
$strings["update_newsdesk"] = "Update Entries";
$strings["my_newsdesk"] = "My Newsdesk";
$strings["edit_newsdesk"] = "Edit News Article";
$strings["copy_newsdesk"] = "Copy News Article";
$strings["add_newsdesk"] = "Add News Article";
$strings["del_newsdesk"] = "Delete News Article";
$strings["delete_news_note"] = "Note: This will delete also all comments for the select news article";
$strings["author"] = "Author";
$strings["blank_newsdesk_title"] = "Blank title found";
$strings["blank_newsdesk"] = "The news cannot be located.";
$strings["blank_newsdesk_comment"] = "Blank comment found";
$strings["remove_newsdesk"] = "The News Article has been successfully deleted with all its comments";
$strings["add_newsdesk_comment"] = "Add a comment to the News Article";
$strings["edit_newsdesk_comment"] = "Edit the comment of the News Article";
$strings["del_newsdesk_comment"] = "Delete the comment/s of the News Article";
$strings["remove_newsdesk_comment"] = "The Comment of the News Article has been successfully deleted";


You'll find the modify code of the newsdesk here:
http://nanoc.no-ip.org/phpcollab/

ciauz
MOD: phpCollab 2.5 patched [message #2145] Tue, 03 June 2003 11:31 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

ok the session error is resolved Very Happy

I've write this patch so please download the phpC-patched if you have done before.

ciuaz
next release [message #2151] Wed, 04 June 2003 12:40 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

in the next release:
- I'll remove XOOP integration
- I'll add in the newsDesk the htmlArea js (screenshot), this js works fine with mozilla 1.3+ (but not with firebird 0.6) and ie 5.5+
- I'll correct some little bug (like erroneus scripts[] references)

please vote to decide what kind of security level to use.

ciuaz
Going from v2.4 to new v2.5Beta w/ patches ... [message #2157] Thu, 05 June 2003 04:45 Go to previous messageGo to next message
redbox2000 is currently offline  redbox2000
Messages: 81
Registered: February 2003
Location: Connecticut
phpCollab lover
This is some great work you, urbanfalcon, etc. have done. I understand that you have implemented quite a few of urbanfalcon's MODs.

I have now 8 client installations of phpCollab v2.4 that I've customized to fit our needs. I have also started to implement some of the same changes/MODs to the v2.4 code, but I'm wondering if I shouldn't just switch over to your v2.5 instead.

My question is this: how different is the v2.5 code from v2.4. Can you tell me if there are a lot of changes to the code base, or a lot of additions, or both?

TIA,
-martin.
I think I'm in the same boat... [message #2159] Thu, 05 June 2003 04:56 Go to previous messageGo to next message
urbanfalcon is currently offline  urbanfalcon
Messages: 235
Registered: January 2003
Location: new york
phpCollab contributor
Site Admin

I like what I'm seeing with what fullo is calling version 2.5, but I am also wary of upgrading entirely at this point. I think that's why I'm just leaning more towards modifying code versus overhauling. I think fullo's new variation would work well, but I would want it to be tested to see how to successfully and reliably it could get to the 2.5 level from a 2.3 or 2.4 installation before I took the plunge. I don't have a ton of time, and at this point I can't afford to break my working phpCollab installation. Once fullo is done, if someone would be willing to play the beta tester...view the changes, take a standard installation of 2.3 and 2.4 and see how to get a successful upgrade...then I would be a lot more confident. As it is, I will probably try to implement his NewsDesk2.0 as a standalone upgrade once development on that is complete. If everything works as well as the screenshots look, NewsDesk2.0 will be a powerful addition.
MOD: phpCollab 2.5 patched [message #2170] Thu, 05 June 2003 21:57 Go to previous messageGo to next message
fullo is currently offline  fullo
Messages: 390
Registered: January 2003
Location: faenza (ra)
phpCollab contributor
phpCollab Project Leader

urbanfalcon

I like what I'm seeing with what fullo is calling version 2.5

I use the phpC 2.5 beta code posted in sourceforge, is less different from the 2.4 rebuild (april), and has a minimal implementation of the invoice module... (i want to try to finish it.. in the future)

to the 2.5 code I've added an upgrader from 2.4 official, so the db will be correctly updated (I've modded the setup.php and the db files in the include/ dir), and a working login function (for php 4.3.x).

I'm sorry but I can update the version only once a week 'coz my nanoc server is at home and I've not yet installed a ftp server Wink
next week I'll create a new page on a free php-hosting, (if you want to help me please visit this page and click the banner so they give me the mySQL account Wink I need only 25 more clicks)

and at the end, this is the new todo list for the newdesk 2.0 mod:
- add permission: admin, project admin
- comment permission: everyone registered
- a new block in the users home page with the news and the button to
add a comment

and after I'll try to add this
- news divided in project's news (only team and clients can see) and generic news (for all users)

any suggestion or requests?

ciuaz
MOD: phpCollab 2.5 patched [message #2189] Sat, 07 June 2003 01:02 Go to previous messageGo to next message
abilstein is currently offline  abilstein
Messages: 5
Registered: January 2003
phpCollab guest

Sounds interesting so far. I made my own news mod some time ago, so I'm curious to see how yours is implemented but I can't hit your server.

I also made a full FAQ mod with categories if anyone wants to play with it. It needs to be generalized before posting which is why I haven't done it so far.

Added a name field to document upload instead of relying on file name. This is very handy and I'll post I have a chance to go back and look at it and generalize it.

I also would like to see someone add Notes functionality to the Project Site. Currently you can Publish notes in the User side, but clients can't actually see them (this was scheduled for a future version).
coolahs [message #2196] Sun, 08 June 2003 03:10 Go to previous messageGo to previous message
urbanfalcon is currently offline  urbanfalcon
Messages: 235
Registered: January 2003
Location: new york
phpCollab contributor
Site Admin

I logged into fullo's demo installation...but Newsdesk is locked for anyone but ADMIN! Ahhhhh!!! Crying or Very Sad I wanted to see how it worked. At least I got to see some of the new things used in this version of phpC. I like the little color-coded priority labels. I think you should also add in the Support Requests on the Home page...it's been a lifesaver for me. I think the code was posted somewhere in this site to include it.
Previous Topic: invoicing hack:phpCollab 2.4
Next Topic: Shared Calendar Here
Goto Forum:
  


Current Time: Sat May 25 12:28:28 CEST 2013

Total time taken to generate the page: 0.11697 seconds